Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Fixes NDArray.toDevice() missing name issue #2751

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[api] Fixes NDArray.toDevice() missing name issue #2751

merged 1 commit into from
Aug 17, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners August 16, 2023 21:26
@frankfliu frankfliu changed the title [api] Fixed NDArray.toDevice() missing name issue [api] Fixes NDArray.toDevice() missing name issue Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 54.49% and project coverage change: +0.06% 🎉

Comparison is base (bb5073f) 72.08% compared to head (ef70bd9) 72.15%.
Report is 874 commits behind head on master.

❗ Current head ef70bd9 differs from pull request most recent head 49379c5. Consider uploading reports for the commit 49379c5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2751      +/-   ##
============================================
+ Coverage     72.08%   72.15%   +0.06%     
- Complexity     5126     7056    +1930     
============================================
  Files           473      700     +227     
  Lines         21970    31434    +9464     
  Branches       2351     3249     +898     
============================================
+ Hits          15838    22681    +6843     
- Misses         4925     7205    +2280     
- Partials       1207     1548     +341
Files Changed Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...djl/modality/cv/transform/RandomFlipLeftRight.java 25.00% <0.00%> (-25.00%) ⬇️
...djl/modality/cv/transform/RandomFlipTopBottom.java 25.00% <0.00%> (-25.00%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 226 more

... and 370 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu mentioned this pull request Aug 16, 2023
Closed
@frankfliu frankfliu merged commit 59af05f into deepjavalibrary:master Aug 17, 2023
5 checks passed
@frankfliu frankfliu deleted the nd branch August 17, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgk zachgk zachgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankfliu @codecov-commenter @zachgk